Thread (40 messages) 40 messages, 4 authors, 2022-01-07

Re: [PATCH 3/9] powerpc/bpf: Remove unused SEEN_STACK

From: Naveen N. Rao <hidden>
Date: 2021-10-05 20:22:35
Also in: bpf

Christophe Leroy wrote:

Le 04/10/2021 à 20:11, Naveen N. Rao a écrit :
quoted
Christophe Leroy wrote:
quoted

Le 01/10/2021 à 23:14, Naveen N. Rao a écrit :
quoted
From: Ravi Bangoria <redacted>

SEEN_STACK is unused on PowerPC. Remove it. Also, have
SEEN_TAILCALL use 0x40000000.
Why change SEEN_TAILCALL ? Would it be a problem to leave it as is ?
quoted
Signed-off-by: Ravi Bangoria <redacted>
Reviewed-by: Christophe Leroy <redacted>
I prefer the bit usage to be contiguous. Changing SEEN_TAILCALL isn't a 
problem either.
Well you are adding SEEN_BIG_PROG in following patch so it would still 
be contiguous at the end.

I don't really mind but I thought it would be less churn to just leave 
SEEN_TAILCALL as is and re-use 0x40000000 for SEEN_BIG_PROG.
Ah ok. This patch was from a different series and it made more sense to 
change the bit number there. I have reused the patch here as-is since 
the change is fairly trivial.


- Naveen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help