Re: [PATCH 07/20] signal/powerpc: On swapcontext failure force SIGSEGV

From
Kees Cook <hidden>
Date
2021-10-21 16:09:47
Also in
linux-arch, lkml
Reply to
Eric W. Biederman, 2021-10-20
On Wed, Oct 20, 2021 at 12:43:53PM -0500, Eric W. Biederman wrote:
If the register state may be partial and corrupted instead of calling
do_exit, call force_sigsegv(SIGSEGV).  Which properly kills the
process with SIGSEGV and does not let any more userspace code execute,
instead of just killing one thread of the process and potentially
confusing everything.

Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <redacted>
Cc: <redacted>
History-tree: git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
Fixes: 756f1ae8a44e ("PPC32: Rework signal code and add a swapcontext system call.")
Fixes: 04879b04bf50 ("[PATCH] ppc64: VMX (Altivec) support & signal32 rework, from Ben Herrenschmidt")
Signed-off-by: "Eric W. Biederman" <redacted>
This looks right to me.

Reviewed-by: Kees Cook <redacted>

-- 
Kees Cook
Thread (3 messages) 3 messages, 2 authors, last reply 2021-10-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help