Re: [PATCH] powerpc/kexec_file: Add of_node_put() before goto
From: Hari Bathini <hbathini@linux.ibm.com>
Date: 2021-10-18 07:08:00
Also in:
lkml
On 18/10/21 7:24 am, Wan Jiabing wrote:
Fix following coccicheck warning: ./arch/powerpc/kexec/file_load_64.c:698:1-22: WARNING: Function for_each_node_by_type should have of_node_put() before goto Early exits from for_each_node_by_type should decrement the node reference counter. Signed-off-by: Wan Jiabing <redacted>
Thanks for fixing this! Acked-by: Hari Bathini <hbathini@linux.ibm.com>
quoted hunk ↗ jump to hunk
--- arch/powerpc/kexec/file_load_64.c | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c index 5056e175ca2c..b4981b651d9a 100644 --- a/arch/powerpc/kexec/file_load_64.c +++ b/arch/powerpc/kexec/file_load_64.c@@ -700,6 +700,7 @@ static int update_usable_mem_fdt(void *fdt, struct crash_mem *usable_mem) if (ret) { pr_err("Failed to set linux,usable-memory property for %s node", dn->full_name); + of_node_put(dn); goto out; } }