[PATCH AUTOSEL 5.10 01/26] ibmvnic: check failover_pending in login response

Subsystems: ibm power sriov virtual nic device driver, linux for powerpc (32-bit and 64-bit), networking drivers, the rest

STALE1803d

3 messages, 2 authors, 2021-09-24 · open the first message on its own page

[PATCH AUTOSEL 5.10 01/26] ibmvnic: check failover_pending in login response

From: Sasha Levin <sashal@kernel.org>
Date: 2021-09-23 03:38:58

From: Sukadev Bhattiprolu <redacted>

[ Upstream commit d437f5aa23aa2b7bd07cd44b839d7546cc17166f ]

If a failover occurs before a login response is received, the login
response buffer maybe undefined. Check that there was no failover
before accessing the login response buffer.

Signed-off-by: Sukadev Bhattiprolu <redacted>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/net/ethernet/ibm/ibmvnic.c | 8 ++++++++
 1 file changed, 8 insertions(+)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 3134c1988db3..bb8d0a0f48ee 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -4478,6 +4478,14 @@ static int handle_login_rsp(union ibmvnic_crq *login_rsp_crq,
 		return 0;
 	}
 
+	if (adapter->failover_pending) {
+		adapter->init_done_rc = -EAGAIN;
+		netdev_dbg(netdev, "Failover pending, ignoring login response\n");
+		complete(&adapter->init_done);
+		/* login response buffer will be released on reset */
+		return 0;
+	}
+
 	netdev->mtu = adapter->req_mtu - ETH_HLEN;
 
 	netdev_dbg(adapter->netdev, "Login Response Buffer:\n");
-- 
2.30.2

Re: [PATCH AUTOSEL 5.10 01/26] ibmvnic: check failover_pending in login response

From: Pavel Machek <hidden>
Date: 2021-09-23 07:33:52

Hi!

Something went wrong with this series. I only see first 7 patches. I
thought it might be local problem, but I only see 7 patches on lore...

https://lore.kernel.org/lkml/20210923033839.1421034-1-sashal@kernel.org/

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Re: [PATCH AUTOSEL 5.10 01/26] ibmvnic: check failover_pending in login response

From: Sasha Levin <sashal@kernel.org>
Date: 2021-09-24 11:47:56

On Thu, Sep 23, 2021 at 09:33:47AM +0200, Pavel Machek wrote:
Hi!

Something went wrong with this series. I only see first 7 patches. I
thought it might be local problem, but I only see 7 patches on lore...
Huh, yes, apparently git-send-email timed out. I'll resend. Thanks!


-- 
Thanks,
Sasha
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help