Re: [PATCH v5 4/6] sched/fair: Provide update_sg_lb_stats() with sched domain statistics
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: 2021-09-17 15:27:17
Also in:
lkml
On Sat, 11 Sept 2021 at 03:19, Ricardo Neri [off-list ref] wrote:
Before deciding to pull tasks when using asymmetric packing of tasks, on some architectures (e.g., x86) it is necessary to know not only the state of dst_cpu but also of its SMT siblings. The decision to classify a candidate busiest group as group_asym_packing is done in update_sg_lb_stats(). Give this function access to the scheduling domain statistics, which contains the statistics of the local group. Cc: Aubrey Li <redacted> Cc: Ben Segall <bsegall@google.com> Cc: Daniel Bristot de Oliveira <redacted> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> Cc: Mel Gorman <mgorman@suse.de> Cc: Quentin Perret <redacted> Cc: Rafael J. Wysocki <redacted> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Tim Chen <redacted> Reviewed-by: Joel Fernandes (Google) <redacted> Reviewed-by: Len Brown <redacted> Originally-by: Peter Zijlstra (Intel) [off-list ref] Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Ricardo Neri <redacted>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
quoted hunk ↗ jump to hunk
--- Changes since v4: * None Changes since v3: * None Changes since v2: * Introduced this patch. Changes since v1: * N/A --- kernel/sched/fair.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 7a054f528bcc..c5851260b4d8 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c@@ -8605,6 +8605,7 @@ group_type group_classify(unsigned int imbalance_pct, * @sg_status: Holds flag indicating the status of the sched_group */ static inline void update_sg_lb_stats(struct lb_env *env, + struct sd_lb_stats *sds, struct sched_group *group, struct sg_lb_stats *sgs, int *sg_status)@@ -8613,7 +8614,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, memset(sgs, 0, sizeof(*sgs)); - local_group = cpumask_test_cpu(env->dst_cpu, sched_group_span(group)); + local_group = group == sds->local; for_each_cpu_and(i, sched_group_span(group), env->cpus) { struct rq *rq = cpu_rq(i);@@ -9176,7 +9177,7 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd update_group_capacity(env->sd, env->dst_cpu); } - update_sg_lb_stats(env, sg, sgs, &sg_status); + update_sg_lb_stats(env, sds, sg, sgs, &sg_status); if (local_group) goto next_group; --2.17.1