Re: [RFC PATCH] drivers/nvdimm: nvdimm_pmu_free_hotplug_memory() can be static
From: kajoljain <hidden>
Date: 2021-09-04 06:40:22
Also in:
lkml, nvdimm, oe-kbuild-all
On 9/3/21 8:49 PM, kernel test robot wrote:
quoted hunk ↗ jump to hunk
drivers/nvdimm/nd_perf.c:159:6: warning: symbol 'nvdimm_pmu_free_hotplug_memory' was not declared. Should it be static? Reported-by: kernel test robot <redacted> Signed-off-by: kernel test robot <redacted> --- nd_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/nvdimm/nd_perf.c b/drivers/nvdimm/nd_perf.c index 4c49d1bc2a3c6..b129e5e702d59 100644 --- a/drivers/nvdimm/nd_perf.c +++ b/drivers/nvdimm/nd_perf.c@@ -156,7 +156,7 @@ static int nvdimm_pmu_cpu_hotplug_init(struct nvdimm_pmu *nd_pmu) return 0; } -void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu) +static void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu) { cpuhp_state_remove_instance_nocalls(nd_pmu->cpuhp_state, &nd_pmu->node); cpuhp_remove_multi_state(nd_pmu->cpuhp_state);
Hi, Thanks for reporting this issue, I will merge it in my followup patchset. Thanks, Kajol Jain