Re: [PATCH 1/6] powerpc/prom: Introduce early_reserve_mem_old()

Christophe Leroy [off-list ref] writes:

Le 19/08/2021 à 14:56, Cédric Le Goater a écrit :

quoted

and condition its call with IS_ENABLED(CONFIG_PPC32). This fixes a
compile error with W=1.

arch/powerpc/kernel/prom.c: In function ‘early_reserve_mem’:
arch/powerpc/kernel/prom.c:625:10: error: variable ‘reserve_map’ set but not used [-Werror=unused-but-set-variable]
   __be64 *reserve_map;
           ^~~~~~~~~~~
cc1: all warnings being treated as errors

Cc: Christophe Leroy <redacted>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---

  Christophe, I think you had comments on this one ? Yes, I am being a bit lazy.

Yeah, my comment was to leave thing almost as is, just drop the #ifdef CONFIG_PPC32 and instead put 
something like:

	if (!IS_ENABLED(CONFIG_PPC32))
		return;

Yeah that's cleaner, let's do that.

cheers