Thread (9 messages) read the whole thread 9 messages, 4 authors, 2021-08-13

Re: [PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars()

From: Jiri Slaby <jirislaby@kernel.org>
Date: 2021-08-13 05:54:04
Also in: lkml, oe-kbuild-all

Hi,

On 12. 08. 21, 14:26, kernel test robot wrote:
quoted
quoted
drivers/tty/hvc/hvc_console.c:190:26: warning: variable 'hp' is uninitialized when used here [-Wuninitialized]
            spin_unlock_irqrestore(&hp->c_lock, flags);
                                    ^~
    drivers/tty/hvc/hvc_console.c:149:23: note: initialize the variable 'hp' to silence this warning
            struct hvc_struct *hp;
                                 ^
                                  = NULL
So you clearly didn't test your change as it would crash quite 
instantly. I wonder, where do you intend to get hp from in the 
console::print() hook?

thanks,
-- 
js
suse labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help