Re: [PATCH v4 08/10] net/ps3_gelic: Rename no to descr_count
From: Christophe Leroy <hidden>
Date: 2021-07-25 18:22:37
Also in:
netdev
Geoff Levand [off-list ref] a écrit :
In an effort to make the PS3 gelic driver easier to maintain, rename the gelic_card_init_chain parameter 'no' to 'descr_count'.
Not sure you really need a so long name. 'count' should be good enough. Read https://www.kernel.org/doc/html/latest/process/coding-style.html#naming
quoted hunk ↗ jump to hunk
Signed-off-by: Geoff Levand <geoff@infradead.org> --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.cb/drivers/net/ethernet/toshiba/ps3_gelic_net.c index e55aa9fecfeb..60fcca5d20dd 100644--- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c@@ -325,7 +325,7 @@ static void gelic_card_free_chain(structgelic_card *card, * @card: card structure * @chain: address of chain * @start_descr: address of descriptor array - * @no: number of descriptors + * @descr_count: number of descriptors * * we manage a circular list that mirrors the hardware structure, * except that the hardware uses bus addresses.@@ -334,16 +334,16 @@ static void gelic_card_free_chain(structgelic_card *card, */ static int gelic_card_init_chain(struct gelic_card *card, struct gelic_descr_chain *chain, struct gelic_descr *start_descr, - int no) + int descr_count) { int i; struct gelic_descr *descr; struct device *dev = ctodev(card); descr = start_descr; - memset(descr, 0, sizeof(*descr) * no); + memset(descr, 0, sizeof(*descr) *descr_count);
You forgot the space after the * Christophe
quoted hunk ↗ jump to hunk
- for (i = 0; i < no; i++, descr++) { + for (i = 0; i < descr_count; i++, descr++) { descr->link.size = sizeof(struct gelic_hw_regs); gelic_descr_set_status(descr, GELIC_DESCR_DMA_NOT_IN_USE); descr->link.cpu_addr =@@ -361,7 +361,7 @@ static int gelic_card_init_chain(struct gelic_card *card, start_descr->prev = (descr - 1); descr = start_descr; - for (i = 0; i < no; i++, descr++) { + for (i = 0; i < descr_count; i++, descr++) { descr->hw_regs.next_descr_addr = cpu_to_be32(descr->next->link.cpu_addr); } --2.25.1