Re: [PATCH 2/2] powerpc/bpf: Reject atomic ops in ppc32 JIT

Christophe Leroy wrote:

Le 01/07/2021 à 17:08, Naveen N. Rao a écrit :

quoted

Commit 91c960b0056672 ("bpf: Rename BPF_XADD and prepare to encode other
atomics in .imm") converted BPF_XADD to BPF_ATOMIC and updated all JIT
implementations to reject JIT'ing instructions with an immediate value
different from BPF_ADD. However, ppc32 BPF JIT was implemented around
the same time and didn't include the same change. Update the ppc32 JIT
accordingly.

Signed-off-by: Naveen N. Rao <redacted>

Shouldn't it also include a Fixes tag and stable Cc as PPC32 eBPF was added in 5.13 ?

Yes, I wasn't sure which patch to actually blame. But you're right, this 
should have the below fixes tag since this affects the ppc32 eBPF JIT.

Fixes: 51c66ad849a7 ("powerpc/bpf: Implement extended BPF on PPC32")
Cc: stable@vger.kernel.org

Cc: stable@vger.kernel.org # v5.13


Thanks,
- Naveen