Thread (8 messages) 8 messages, 4 authors, 2021-08-02

Re: [PATCH v1 4/5] PCI: Adapt all code locations to not use struct pci_dev::driver directly

From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Date: 2021-07-30 20:39:24
Also in: linux-crypto, linux-pci, linux-perf-users, linux-scsi, linux-usb, linux-wireless, lkml, netdev, xen-devel

On 7/29/21 4:37 PM, Uwe Kleine-König wrote:
quoted hunk ↗ jump to hunk
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -599,12 +599,12 @@ static pci_ers_result_t pcifront_common_process(int cmd,
 	result = PCI_ERS_RESULT_NONE;
 
 	pcidev = pci_get_domain_bus_and_slot(domain, bus, devfn);
-	if (!pcidev || !pcidev->driver) {
+	pdrv = pci_driver_of_dev(pcidev);
+	if (!pcidev || !pdrv) {

If pcidev is NULL we are dead by the time we reach 'if' statement.


-boris


 		dev_err(&pdev->xdev->dev, "device or AER driver is NULL\n");
 		pci_dev_put(pcidev);
 		return result;
 	}
-	pdrv = pcidev->driver;
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help