Re: [PATCH v2 4/4] bus: Make remove callback return void

From
Ulf Hansson <hidden>
Date
2021-07-08 12:41:48
Also in
dmaengine, kvm, linux-acpi, linux-arm-msm, linux-cxl, linux-fpga, linux-hyperv, linux-i2c, linux-i3c, linux-input, linux-media, linux-mips, linux-mmc, linux-pci, linux-remoteproc, linux-scsi, linux-serial, linux-spi, linux-staging, linux-sunxi, linux-usb, linux-wireless, lkml, netdev, nvdimm, platform-driver-x86, target-devel, virtualization, xen-devel
Reply to
Uwe Kleine-König, 2021-07-06
On Tue, 6 Jul 2021 at 17:53, Uwe Kleine-König
[off-list ref] wrote:
The driver core ignores the return value of this callback because there
is only little it can do when a device disappears.

This is the final bit of a long lasting cleanup quest where several
buses were converted to also return void from their remove callback.
Additionally some resource leaks were fixed that were caused by drivers
returning an error code in the expectation that the driver won't go
away.

With struct bus_type::remove returning void it's prevented that newly
implemented buses return an ignored error code and so don't anticipate
wrong expectations for driver authors.

Acked-by: Russell King (Oracle) <redacted> (For ARM, Amba and related parts)
Acked-by: Mark Brown <broonie@kernel.org>
Acked-by: Chen-Yu Tsai <redacted> (for drivers/bus/sunxi-rsb.c)
Acked-by: Pali Rohár <pali@kernel.org>
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org> (for drivers/media)
Acked-by: Hans de Goede <redacted> (For drivers/platform)
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-By: Vinod Koul <vkoul@kernel.org>
Acked-by: Juergen Gross <jgross@suse.com> (For Xen)
Acked-by: Lee Jones <redacted> (For drivers/mfd)
Acked-by: Johannes Thumshirn <jth@kernel.org> (For drivers/mcb)
Acked-by: Johan Hovold <johan@kernel.org>
Acked-by: Srinivas Kandagatla <redacted> (For drivers/slimbus)
Acked-by: Kirti Wankhede <kwankhede@nvidia.com> (For drivers/vfio)
Acked-by: Maximilian Luz <luzmaximilian@gmail.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> (For ulpi and typec)
Acked-by: Samuel Iglesias Gonsálvez <redacted> (For ipack)
Reviewed-by: Tom Rix <trix@redhat.com> (For fpga)
Acked-by: Geoff Levand <geoff@infradead.org> (For ps3)
Signed-off-by: Uwe Kleine-König <redacted>
Acked-by: Ulf Hansson <redacted> # For MMC

[...]

Kind regards
Uffe
Thread (17 messages) 17 messages, 12 authors, last reply 2021-07-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help