Re: [PATCH] ASoC: fsl-asoc-card: change dev_err to dev_dbg for defer probe
flat view
From: Fabio Estevam <festevam@gmail.com>
Date: 2021-06-22 02:15:54
Also in:
alsa-devel, lkml
Hi Shengjiu, On Wed, Jun 2, 2021 at 3:59 AM Shengjiu Wang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Don't need to print error message for defer probe Signed-off-by: Shengjiu Wang <redacted> --- sound/soc/fsl/fsl-asoc-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index 4f55b316cf0f..b40ba910ae9d 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c@@ -709,7 +709,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev) of_node_put(framemaster); if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) { - dev_err(&pdev->dev, "failed to find codec device\n"); + dev_dbg(&pdev->dev, "failed to find codec device\n"); ret = -EPROBE_DEFER;
This looks good: Reviewed-by: Fabio Estevam <festevam@gmail.com> My previous suggestion of using dev_err_probe() would make the message never to be printed. Thanks