Thread (5 messages) 5 messages, 4 authors, 2021-06-21

Re: [PATCH] ASoC: fsl_xcvr: disable all interrupts when suspend happens

flat view

From: Fabio Estevam <festevam@gmail.com>
Date: 2021-06-18 11:20:54
Also in: alsa-devel, lkml

Hi Shengjiu,

On Fri, Jun 18, 2021 at 7:10 AM Shengjiu Wang [off-list ref] wrote:
There is an unhandled interrupt after suspend, which cause endless
interrupt when system resume, so system may hang.

Disable all interrupts in runtime suspend callback to avoid above
issue.
Fixe tag?
quoted hunk ↗ jump to hunk
+       ret = regmap_update_bits(xcvr->regmap, FSL_XCVR_EXT_IER0,
+                                FSL_XCVR_IRQ_EARC_ALL, 0);
+       if (ret < 0)
+               dev_err(dev, "Failed to clear IER0: %d\n", ret);
+
The operations in _suspend() are usually balanced with the ones in _resume().

Shouldn't you enable the interrupts in resume() then?

I see that the interrupts are currently enabled inside fsl_xcvr_prepare().
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help