Re: [PATCH] ASoC:fsl_easrc:Remove superfluous error message around platform_get_irq()
From: Shengjiu Wang <shengjiu.wang@gmail.com>
Date: 2021-06-11 02:23:49
Also in:
alsa-devel, lkml
On Thu, Jun 10, 2021 at 8:52 PM Zhongjun Tan [off-list ref] wrote:
From: Tan Zhongjun <redacted> Clean up the check for irq.dev_err is superfluous as platform_get_irq() already prints an error.Remove curly braces to confirm to styling requirements. Signed-off-by: Tan Zhongjun <redacted>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
quoted hunk ↗ jump to hunk
--- sound/soc/fsl/fsl_easrc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c index b1765c7d3bcd..25747433916e 100644 --- a/sound/soc/fsl/fsl_easrc.c +++ b/sound/soc/fsl/fsl_easrc.c@@ -1901,10 +1901,8 @@ static int fsl_easrc_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "no irq for node %pOF\n", np); + if (irq < 0) return irq; - } ret = devm_request_irq(&pdev->dev, irq, fsl_easrc_isr, 0, dev_name(dev), easrc); --2.17.1