Thread (42 messages) 42 messages, 11 authors, 2021-05-24

Re: Linux powerpc new system call instruction and ABI

From: Matheus Castanho <hidden>
Date: 2021-05-24 20:34:25
Also in: linux-api

Matheus Castanho [off-list ref] writes:
Dmitry V. Levin [off-list ref] writes:
quoted
On Fri, May 21, 2021 at 05:00:36PM -0300, Matheus Castanho wrote:
quoted
Florian Weimer [off-list ref] writes:
quoted
* Matheus Castanho via Libc-alpha:
quoted
From: Nicholas Piggin <npiggin@gmail.com>
Subject: [PATCH 1/1] powerpc: Fix handling of scv return error codes

When using scv on templated ASM syscalls, current code interprets any
negative return value as error, but the only valid error codes are in
the range -4095..-1 according to the ABI.

Reviewed-by: Matheus Castanho <redacted>
Please reference bug 27892 in the commit message.  I'd also appreciate a
backport to the 2.33 release branch (where you need to add NEWS manually
to add the bug reference).
No problem. [BZ #27892] appended to the commit title. I'll make sure to
backport to 2.33 as well.
Could you also mention in the commit message that the change fixes
'signal.gen.test' strace test where it was observed initially?
Sure, no problem. I'll commit it later today.
Since the patch falls into the less-than-15-LOC category and this is
Nick's first contribution to glibc, looks like he doesn't need a
copyright assignment.

Pushed to master as 7de36744ee1325f35d3fe0ca079dd33c40b12267

Backported to 2.33 via commit 0ef0e6de7fdfa18328b09ba2afb4f0112d4bdab4

Thanks,
Matheus Castanho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help