Thread (13 messages) flat view 13 messages, 2 authors, 2021-05-21

Re: [PATCH v2 01/11] powerpc: remove interrupt exit helpers unused argument

From: Christophe Leroy <hidden>
Date: 2021-05-21 17:43:04

Nicholas Piggin [off-list ref] a écrit :
The msr argument is not used, remove it.
Why not keep and use that msr argument instead of re-reading regs->msr ?
quoted hunk ↗ jump to hunk
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 arch/powerpc/include/asm/asm-prototypes.h | 4 ++--
 arch/powerpc/kernel/interrupt.c           | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/include/asm/asm-prototypes.h  
b/arch/powerpc/include/asm/asm-prototypes.h
index 1c7b75834e04..95492655462e 100644
--- a/arch/powerpc/include/asm/asm-prototypes.h
+++ b/arch/powerpc/include/asm/asm-prototypes.h
@@ -71,8 +71,8 @@ void __init machine_init(u64 dt_ptr);
 #endif
 long system_call_exception(long r3, long r4, long r5, long r6, long  
r7, long r8, unsigned long r0, struct pt_regs *regs);
 notrace unsigned long syscall_exit_prepare(unsigned long r3, struct  
pt_regs *regs, long scv);
-notrace unsigned long interrupt_exit_user_prepare(struct pt_regs  
*regs, unsigned long msr);
-notrace unsigned long interrupt_exit_kernel_prepare(struct pt_regs  
*regs, unsigned long msr);
+notrace unsigned long interrupt_exit_user_prepare(struct pt_regs *regs);
+notrace unsigned long interrupt_exit_kernel_prepare(struct pt_regs *regs);

 long ppc_fadvise64_64(int fd, int advice, u32 offset_high, u32 offset_low,
 		      u32 len_high, u32 len_low);
diff --git a/arch/powerpc/kernel/interrupt.c  
b/arch/powerpc/kernel/interrupt.c
index e0938ba298f2..38ae7057d6c2 100644
--- a/arch/powerpc/kernel/interrupt.c
+++ b/arch/powerpc/kernel/interrupt.c
@@ -352,7 +352,7 @@ notrace unsigned long  
syscall_exit_prepare(unsigned long r3,
 	return ret;
 }

-notrace unsigned long interrupt_exit_user_prepare(struct pt_regs  
*regs, unsigned long msr)
+notrace unsigned long interrupt_exit_user_prepare(struct pt_regs *regs)
 {
 	unsigned long ti_flags;
 	unsigned long flags;
@@ -431,7 +431,7 @@ notrace unsigned long  
interrupt_exit_user_prepare(struct pt_regs *regs, unsigned

 void preempt_schedule_irq(void);

-notrace unsigned long interrupt_exit_kernel_prepare(struct pt_regs  
*regs, unsigned long msr)
+notrace unsigned long interrupt_exit_kernel_prepare(struct pt_regs *regs)
 {
 	unsigned long flags;
 	unsigned long ret = 0;
--
2.23.0
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help