Thread (5 messages) flat view 5 messages, 4 authors, 2021-05-06

Re: [PATCH] KVM: PPC: Book3S HV: Fix conversion to gfn-based MMU notifier callbacks

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2021-05-06 13:43:55
Also in: kvm

Paolo Bonzini [off-list ref] writes:
On 05/05/21 14:15, Nicholas Piggin wrote:
quoted
Commit b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU notifier
callbacks") causes unmap_gfn_range and age_gfn callbacks to only work
on the first gfn in the range. It also makes the aging callbacks call
into both radix and hash aging functions for radix guests. Fix this.

Add warnings for the single-gfn calls that have been converted to range
callbacks, in case they ever receieve ranges greater than 1.

Fixes: b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU notifier callbacks")
Reported-by: Bharata B Rao <redacted>
Tested-by: Bharata B Rao <redacted>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Sorry for the breakage.  I queued this patch.
Thanks. Are you planning to send it to Linus before rc1?

If not I can pick it up as I already have some things in my next and am
intending to send a pull request anyway.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help