Re: [PATCH 06/26] brd: convert to blk_alloc_disk/blk_cleanup_disk

From
Christoph Hellwig <hch@lst.de>
Date
2021-05-24 07:25:01
Also in
dm-devel, linux-bcache, linux-block, linux-m68k, linux-mmc, linux-nvme, linux-raid, linux-s390, nvdimm
Reply to
Hannes Reinecke, 2021-05-23
On Sun, May 23, 2021 at 09:58:48AM +0200, Hannes Reinecke wrote:
quoted
+	/*
+	 * This is so fdisk will align partitions on 4k, because of
+	 * direct_access API needing 4k alignment, returning a PFN
+	 * (This is only a problem on very small devices <= 4M,
+	 *  otherwise fdisk will align on 1M. Regardless this call
+	 *  is harmless)
+	 */
+	blk_queue_physical_block_size(disk->queue, PAGE_SIZE);
  
Maybe converting the comment to refer to 'PAGE_SIZE' instead of 4k while 
you're at it ...
I really do not want to touch these kinds of unrelated things here.
Thread (75 messages) 75 messages, 8 authors, last reply 2021-06-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help