Re: [PATCH 1/3] lib: early_string: allow early usage of some string functions

From
Daniel Walker <hidden>
Date
2021-05-03 18:07:01
Also in
lkml
Reply to
Daniel Walker, 2021-05-03
On Mon, May 03, 2021 at 11:01:41AM -0700, Daniel Walker wrote:
On Sat, May 01, 2021 at 09:31:47AM +0200, Christophe Leroy wrote:
quoted
quoted
In fact, should be like in prom_init today:

#ifdef __EARLY_STRING_ENABLED
     if (dsize >= count)
         return count;
#else
     BUG_ON(dsize >= count);
#endif
Thinking about it once more, this BUG_ON() is overkill and should be
avoided, see https://www.kernel.org/doc/html/latest/process/deprecated.html

Therefore, something like the following would make it:

	if (dsize >= count) {
		WARN_ON(!__is_defined(__EARLY_STRING_ENABLED));

		return count;
	}
I agree, it's overkill it stop the system for this condition.

how about I do something more like this for my changes,

quoted
	if (WARN_ON(dsize >= count && !__is_defined(__EARLY_STRING_ENABLED)))
		return count;
I'll have to work on this one..

Daniel
Thread (9 messages) 9 messages, 2 authors, last reply 2021-05-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help