Documentation PCI: Fix typo in pci-error-recovery.rst

Started by Wesley Sheng on May 31, 2021 · 4 messages from 4 authors · Last reply Jun 1, 2021

Subsystems (5)

Show 2 more

Maintainers (5)

Show 1 more
STALE1986d LANDED

Status: Landed in mainline as 8e3237989b0d on 2021-06-01.

open the first message on its own page

Wesley Sheng

Message details and related content
Open message details and related content
Replace "It" with "If", since it is a conditional statement.

Signed-off-by: Wesley Sheng <redacted>
---
 Documentation/PCI/pci-error-recovery.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/PCI/pci-error-recovery.rst b/Documentation/PCI/pci-error-recovery.rst
index 84ceebb08cac..187f43a03200 100644
--- a/Documentation/PCI/pci-error-recovery.rst
+++ b/Documentation/PCI/pci-error-recovery.rst
@@ -295,7 +295,7 @@ and let the driver restart normal I/O processing.
 A driver can still return a critical failure for this function if
 it can't get the device operational after reset.  If the platform
 previously tried a soft reset, it might now try a hard reset (power
-cycle) and then call slot_reset() again.  It the device still can't
+cycle) and then call slot_reset() again.  If the device still can't
 be recovered, there is nothing more that can be done;  the platform
 will typically report a "permanent failure" in such a case.  The
 device will be considered "dead" in this case.
-- 
2.25.1

Linas Vepstas replied to Wesley Sheng

Message details and related content
Open message details and related content
Signed-off-by: Linas Vepstas <linasvepstas@gmail.com>

On Mon, May 31, 2021 at 3:12 AM Wesley Sheng [off-list ref] wrote:
quoted hunk
Replace "It" with "If", since it is a conditional statement.

Signed-off-by: Wesley Sheng <redacted>
---
 Documentation/PCI/pci-error-recovery.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/PCI/pci-error-recovery.rst
b/Documentation/PCI/pci-error-recovery.rst
index 84ceebb08cac..187f43a03200 100644
--- a/Documentation/PCI/pci-error-recovery.rst
+++ b/Documentation/PCI/pci-error-recovery.rst
@@ -295,7 +295,7 @@ and let the driver restart normal I/O processing.
 A driver can still return a critical failure for this function if
 it can't get the device operational after reset.  If the platform
 previously tried a soft reset, it might now try a hard reset (power
-cycle) and then call slot_reset() again.  It the device still can't
+cycle) and then call slot_reset() again.  If the device still can't
 be recovered, there is nothing more that can be done;  the platform
 will typically report a "permanent failure" in such a case.  The
 device will be considered "dead" in this case.
--
2.25.1

-- 
Patrick: Are they laughing at us?
Sponge Bob: No, Patrick, they are laughing next to us.

Krzysztof Wilczyński replied to Wesley Sheng

Message details and related content
Open message details and related content
Hi Wesley,

Replace "It" with "If", since it is a conditional statement.
[...]

Nice catch!

-cycle) and then call slot_reset() again.  It the device still can't
+cycle) and then call slot_reset() again.  If the device still can't
[...]

Thank you!

Reviewed-by: Krzysztof Wilczyński <redacted>

	Krzysztof

Bjorn Helgaas replied to Wesley Sheng

Message details and related content
Open message details and related content
On Mon, May 31, 2021 at 04:12:15PM +0800, Wesley Sheng wrote:
Replace "It" with "If", since it is a conditional statement.

Signed-off-by: Wesley Sheng <redacted>
Applied to pci/error for v5.14 with Krzysztof's reviewed-by and
subject "Documentation: PCI: Fix typo in pci-error-recovery.rst" to
match previous convention, thanks!
quoted hunk
---
 Documentation/PCI/pci-error-recovery.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/PCI/pci-error-recovery.rst b/Documentation/PCI/pci-error-recovery.rst
index 84ceebb08cac..187f43a03200 100644
--- a/Documentation/PCI/pci-error-recovery.rst
+++ b/Documentation/PCI/pci-error-recovery.rst
@@ -295,7 +295,7 @@ and let the driver restart normal I/O processing.
 A driver can still return a critical failure for this function if
 it can't get the device operational after reset.  If the platform
 previously tried a soft reset, it might now try a hard reset (power
-cycle) and then call slot_reset() again.  It the device still can't
+cycle) and then call slot_reset() again.  If the device still can't
 be recovered, there is nothing more that can be done;  the platform
 will typically report a "permanent failure" in such a case.  The
 device will be considered "dead" in this case.
-- 
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help