On Thu, 2021-05-20 at 10:21 +0200, Johan Hovold wrote:

On Tue, May 18, 2021 at 12:01:22PM +0800, Xiaofei Tan wrote:

quoted

On 2021/5/17 22:15, Johan Hovold wrote:

quoted

On Mon, May 17, 2021 at 02:37:10PM +0800, Xiaofei Tan wrote:

quoted

Fix coding style issues of block comments, reported by checkpatch.pl.
Besides, add a period at the end of the sentenses.

[]

quoted

quoted

quoted

diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c

[]

quoted

quoted

quoted

@@ -177,7 +177,8 @@ static void hvc_console_print(struct console *co, const char *b,

 			r = cons_ops[index]->put_chars(vtermnos[index], c, i);
 			if (r <= 0) {
 				/* throw away characters on error
-				 * but spin in case of -EAGAIN */
+				 * but spin in case of -EAGAIN.
+				 */

How is this an improvement? First, the multi-line comment style is

	/*
	 * ...
	 */

Yes, mostly we use this style. I can follow it if new version is needed.

This is the preferred style outside of networking.

quoted

BTW, How about add the '/*' check into checkpatch.pl?

Checkpatch already has too many checks IMO

I sometimes agree.  What checkpatch messages do you think are excessive?

and I'm a bit surprised that
it doesn't check this already. Perhaps it's because you used the -f to
run checkpatch on in-kernel code, which you should not.

Likely not.  If it was run on a suggested patch, checkpatch doesn't emit
many messages on unmodified patch context lines.  And it shouldn't.

it's just that you
introduce noise in the logs and do pointless changes of context which
makes it harder to use tools like git blame and makes backporting harder
for no good reason.

Pretty pointless metric IMO.  Context changes in comments are mostly harmless.
IMO: backporting of these sorts non-bug fix changes is done _far_ too often.