Re: [PATCH V2 net] ibmvnic: Continue with reset if set link down failed
From: Lijun Pan <hidden>
Date: 2021-04-22 05:12:48
Also in:
netdev
From: Lijun Pan <hidden>
Date: 2021-04-22 05:12:48
Also in:
netdev
On Wed, Apr 21, 2021 at 3:06 AM Rick Lindsley [off-list ref] wrote:
On 4/20/21 2:42 PM, Lijun Pan wrote:quoted
This v2 does not adddress the concerns mentioned in v1. And I think it is better to exit with error from do_reset, and schedule a thorough do_hard_reset if the the adapter is already in unstable state.But the point is that the testing and analysis has indicated that doing a full hard reset is not necessary. We are about to take the very action which will fix this situation, but currently do not.
The testing was done on this patch. It was not performed on a full hard reset. So I don't think you could even compare the two results.
Please describe the advantage in deferring it further by routing it through do_hard_reset(). I don't see one.
It is not deferred. It exits with error and calls do_hard_reset. See my reply to Suka's.