Re: [PATCH 2/2] powerpc/sstep: Add tests for setb instruction
From: Naveen N. Rao <hidden>
Date: 2021-04-20 17:38:24
Sathvika Vasireddy wrote:
quoted hunk ↗ jump to hunk
This adds selftests for setb instruction. Signed-off-by: Sathvika Vasireddy <redacted> --- arch/powerpc/include/asm/ppc-opcode.h | 1 + arch/powerpc/lib/test_emulate_step.c | 28 +++++++++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+)diff --git a/arch/powerpc/include/asm/ppc-opcode.h b/arch/powerpc/include/asm/ppc-opcode.h index ed161ef2b3ca..32bf53260737 100644 --- a/arch/powerpc/include/asm/ppc-opcode.h +++ b/arch/powerpc/include/asm/ppc-opcode.h@@ -245,6 +245,7 @@ #define PPC_INST_STRING 0x7c00042a #define PPC_INST_STRING_MASK 0xfc0007fe #define PPC_INST_STRING_GEN_MASK 0xfc00067e +#define PPC_INST_SETB 0x7c000100 #define PPC_INST_STSWI 0x7c0005aa #define PPC_INST_STSWX 0x7c00052a #define PPC_INST_TRECHKPT 0x7c0007dddiff --git a/arch/powerpc/lib/test_emulate_step.c b/arch/powerpc/lib/test_emulate_step.c index 783d1b85ecfe..c338e35b627c 100644 --- a/arch/powerpc/lib/test_emulate_step.c +++ b/arch/powerpc/lib/test_emulate_step.c@@ -53,6 +53,8 @@ ppc_inst_prefix(PPC_PREFIX_MLS | __PPC_PRFX_R(pr) | IMM_H(i), \ PPC_RAW_ADDI(t, a, i)) +#define TEST_SETB(t, bfa) ppc_inst(PPC_INST_SETB | ___PPC_RT(t) | ___PPC_RA((bfa & 0x7) << 2)) + static void __init init_pt_regs(struct pt_regs *regs) {@@ -929,6 +931,67 @@ static struct compute_test compute_tests[] = { } } }, + { + .mnemonic = "setb", + .subtests = {
Since this is ISA v3.0, you also need to restrict these tests. You can do that by setting cpu_feature. - Naveen