Re: [PATCH v2 1/2] powerpc: Free fdt on error in elf64_load()
From: Rob Herring <robh@kernel.org>
Date: 2021-04-26 21:25:23
Also in:
linux-devicetree, oe-kbuild-all
From: Rob Herring <robh@kernel.org>
Date: 2021-04-26 21:25:23
Also in:
linux-devicetree, oe-kbuild-all
On Wed, 21 Apr 2021 09:36:09 -0700, Lakshmi Ramasubramanian wrote:
There are a few "goto out;" statements before the local variable "fdt" is initialized through the call to of_kexec_alloc_and_setup_fdt() in elf64_load(). This will result in an uninitialized "fdt" being passed to kvfree() in this function if there is an error before the call to of_kexec_alloc_and_setup_fdt(). If there is any error after fdt is allocated, but before it is saved in the arch specific kimage struct, free the fdt. Reported-by: kernel test robot <redacted> Reported-by: Dan Carpenter <redacted> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Lakshmi Ramasubramanian <redacted> --- arch/powerpc/kexec/elf_64.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-)
Applied, thanks!