Thread (17 messages) 17 messages, 2 authors, 2021-04-30

Re: [PATCH v3 06/11] powerpc/pseries/iommu: Add ddw_property_create() and refactor enable_ddw()

From: Leonardo Bras <hidden>
Date: 2021-04-30 16:06:10
Also in: lkml

On Fri, 2021-04-23 at 19:04 +1000, Alexey Kardashevskiy wrote:
quoted
+	win64->name = kstrdup(propname, GFP_KERNEL);
+	ddwprop = kzalloc(sizeof(*ddwprop), GFP_KERNEL);
+	win64->value = ddwprop;
+	win64->length = sizeof(*ddwprop);
+	if (!win64->name || !win64->value) {
+		kfree(win64);
+		kfree(win64->name);
+		kfree(win64->value);

Wrong order.
Right! Sorry about that. 
Changed for next version!
quoted

+out_del_win:

(I would not bother but since I am commenting on the patch)

nit: the new name is not that much better than the old 
"out_clear_window:" ("out_remove_win" would be a bit better) and it does 
make reviewing a little bit harder. Thanks,
Replaced by out_remove_win
Thanks!



Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help