Re: [PATCH 2/2] powerpc: add ALTIVEC support to lib/ when PPC_FPU not set

On Mon, Apr 19, 2021 at 03:38:02PM +0200, Christophe Leroy wrote:

Le 19/04/2021 à 15:32, Segher Boessenkool a écrit :

quoted

On Sun, Apr 18, 2021 at 01:17:26PM -0700, Randy Dunlap wrote:

quoted

Add ldstfp.o to the Makefile for CONFIG_ALTIVEC and add
externs for get_vr() and put_vr() in lib/sstep.c to fix the
build errors.

quoted

 obj-$(CONFIG_PPC_FPU)	+= ldstfp.o
+obj-$(CONFIG_ALTIVEC)	+= ldstfp.o

It is probably a good idea to split ldstfp.S into two, one for each of
the two configuration options?

Or we can build it all the time and #ifdef the FPU part.

Because it contains FPU, ALTIVEC and VSX stuff.

So it becomes an empty object file if none of the options are selected?
Good idea :-)


Segher