Thread (6 messages) flat view 6 messages, 3 authors, 2021-04-21

Re: [PATCH] powerpc/pseries: Add shutdown() to vio_driver and vio_bus

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2021-04-17 12:30:27
Also in: lkml

Tyrel Datwyler [off-list ref] writes:
On 4/1/21 5:13 PM, Tyrel Datwyler wrote:
quoted
Currently, neither the vio_bus or vio_driver structures provide support
for a shutdown() routine.

Add support for shutdown() by allowing drivers to provide a
implementation via function pointer in their vio_driver struct and
provide a proper implementation in the driver template for the vio_bus
that calls a vio drivers shutdown() if defined.

In the case that no shutdown() is defined by a vio driver and a kexec is
in progress we implement a big hammer that calls remove() to ensure no
further DMA for the devices is possible.

Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com>
---
Ping... any comments, problems with this approach?
The kexec part seems like a bit of a hack.

It also doesn't help for kdump, when none of the shutdown code is run.

How many drivers do we have? Can we just implement a proper shutdown for
them?

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help