Re: [PATCH 2/2] powerpc: make 'boot_text_mapped' static

On 2021/04/08 13:04, Christophe Leroy wrote:

Le 08/04/2021 à 03:18, Yu Kuai a écrit :

quoted

The sparse tool complains as follow:

arch/powerpc/kernel/btext.c:48:5: warning:
  symbol 'boot_text_mapped' was not declared. Should it be static?

This symbol is not used outside of btext.c, so this commit make
it static.

Signed-off-by: Yu Kuai <redacted>
---
  arch/powerpc/kernel/btext.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c
index 359d0f4ca532..8df9230be6fa 100644
--- a/arch/powerpc/kernel/btext.c
+++ b/arch/powerpc/kernel/btext.c

@@ -45,7 +45,7 @@ unsigned long disp_BAT[2] __initdata = {0, 0};

  static unsigned char vga_font[cmapsz];
-int boot_text_mapped __force_data = 0;
+static int boot_text_mapped __force_data;

Are you sure the initialisation to 0 can be removed ? Usually 
initialisation to 0 is not needed because not initialised variables go 
in the BSS section which is zeroed at startup. But here the variable is 
flagged with __force_data so it is not going in the BSS section.

Hi,

I removed the initialisation to 0 because checkpatch complained about
it, I do not familiar with '__force_data', thanks for pointing it out.

Thanks,
Yu Kuai

quoted

  extern void rmci_on(void);
  extern void rmci_off(void);

.