Thread (4 messages) flat view 4 messages, 3 authors, 2021-04-09

Re: [PATCH] powerpc/dts: fix not include DTC_FLAGS

From: Rob Herring <robh+dt@kernel.org>
Date: 2021-04-07 19:59:11
Also in: linux-devicetree, lkml

On Wed, Apr 7, 2021 at 6:27 AM Michael Ellerman [off-list ref] wrote:
Youlin Song [off-list ref] writes:
quoted
I wanted to build the fsl dts in my machine and found that
the dtb have not extra space,so uboot will cause about
FDT_ERR_NOSPACE issue.
How do we not have issues with arm and arm64 boards which don't have
padding? Or what took so long to notice on powerpc?
quoted
Signed-off-by: Youlin Song <redacted>
---
 arch/powerpc/boot/dts/Makefile | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/boot/dts/Makefile b/arch/powerpc/boot/dts/Makefile
index fb335d05aae8..c21165c0cd76 100644
--- a/arch/powerpc/boot/dts/Makefile
+++ b/arch/powerpc/boot/dts/Makefile
@@ -2,5 +2,6 @@

 subdir-y += fsl

+DTC_FLAGS   ?= -p 1024
 dtstree              := $(srctree)/$(src)
 dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
I guess that was missed in 1acf1cf8638a ("powerpc: build .dtb files in dts directory").

Which I think means the assignment to DTC_FLAGS in
arch/powerpc/boot/Makefile is not needed anymore.

Can you send a v2 removing that assignment and explaining that's what
happened?
I've wanted to make this common, but I guess that's a separate change.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help