Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers
From: Mike Rapoport <rppt@kernel.org>
Date: 2021-04-06 14:39:37
Also in:
kexec, linux-arch, linux-fsdevel, linux-hyperv, linux-remoteproc, lkml, rcu
On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote:
kernel.h is being used as a dump for all kinds of stuff for a long time. Here is the attempt to start cleaning it up by splitting out panic and oops helpers. At the same time convert users in header and lib folder to use new header. Though for time being include new header back to kernel.h to avoid twisted indirected includes for existing users. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mike Rapoport <redacted>
quoted hunk ↗ jump to hunk
--- arch/powerpc/kernel/setup-common.c | 1 + arch/x86/include/asm/desc.h | 1 + arch/x86/kernel/cpu/mshyperv.c | 1 + arch/x86/kernel/setup.c | 1 + drivers/char/ipmi/ipmi_msghandler.c | 1 + drivers/remoteproc/remoteproc_core.c | 1 + include/asm-generic/bug.h | 3 +- include/linux/kernel.h | 84 +----------------------- include/linux/panic.h | 98 ++++++++++++++++++++++++++++ include/linux/panic_notifier.h | 12 ++++ kernel/hung_task.c | 1 + kernel/kexec_core.c | 1 + kernel/panic.c | 1 + kernel/rcu/tree.c | 2 + kernel/sysctl.c | 1 + kernel/trace/trace.c | 1 + 16 files changed, 126 insertions(+), 84 deletions(-) create mode 100644 include/linux/panic.h create mode 100644 include/linux/panic_notifier.hdiff --git a/arch/x86/include/asm/desc.h b/arch/x86/include/asm/desc.h index 476082a83d1c..ceb12683b6d1 100644 --- a/arch/x86/include/asm/desc.h +++ b/arch/x86/include/asm/desc.h@@ -9,6 +9,7 @@ #include <asm/irq_vectors.h> #include <asm/cpu_entry_area.h> +#include <linux/debug_locks.h>
This seems unrelated, but I might be missing something.
#include <linux/smp.h> #include <linux/percpu.h>
-- Sincerely yours, Mike.