[PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1943d LANDED

Landed in mainline as 66d9b7492887 on 2021-04-22.

3 messages, 3 authors, 2021-04-29 · open the first message on its own page

[PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10

From: Athira Rajeev <hidden>
Date: 2021-03-04 06:40:57

Memory events (mem-loads and mem-stores) currently use the threshold
event selection as issue to finish. Power10 supports issue to complete
as part of thresholding which is more appropriate for mem-loads and
mem-stores. Hence fix the event code for memory events to use issue
to complete.

Fixes: a64e697cef23 ("powerpc/perf: power10 Performance Monitoring support")
Signed-off-by: Athira Rajeev <redacted>
---
 arch/powerpc/perf/power10-events-list.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/perf/power10-events-list.h b/arch/powerpc/perf/power10-events-list.h
index e45dafe818ed..93be7197d250 100644
--- a/arch/powerpc/perf/power10-events-list.h
+++ b/arch/powerpc/perf/power10-events-list.h
@@ -75,5 +75,5 @@
  *     thresh end (TE)
  */
 
-EVENT(MEM_LOADS,				0x34340401e0);
-EVENT(MEM_STORES,				0x343c0401e0);
+EVENT(MEM_LOADS,				0x35340401e0);
+EVENT(MEM_STORES,				0x353c0401e0);
-- 
1.8.3.1

Re: [PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10

From: Madhavan Srinivasan <maddy@linux.ibm.com>
Date: 2021-03-09 11:29:17

On 3/4/21 12:10 PM, Athira Rajeev wrote:
Memory events (mem-loads and mem-stores) currently use the threshold
event selection as issue to finish. Power10 supports issue to complete
as part of thresholding which is more appropriate for mem-loads and
mem-stores. Hence fix the event code for memory events to use issue
to complete.
Changes looks fine to me.

Reviewed-by: Madhavan Srinivasan <maddy@linux.ibm.com>

We should also CC stable to include this fix?

quoted hunk
Fixes: a64e697cef23 ("powerpc/perf: power10 Performance Monitoring support")
Signed-off-by: Athira Rajeev <redacted>
---
  arch/powerpc/perf/power10-events-list.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/perf/power10-events-list.h b/arch/powerpc/perf/power10-events-list.h
index e45dafe818ed..93be7197d250 100644
--- a/arch/powerpc/perf/power10-events-list.h
+++ b/arch/powerpc/perf/power10-events-list.h
@@ -75,5 +75,5 @@
   *     thresh end (TE)
   */
  
-EVENT(MEM_LOADS,				0x34340401e0);
-EVENT(MEM_STORES,				0x343c0401e0);
+EVENT(MEM_LOADS,				0x35340401e0);
+EVENT(MEM_STORES,				0x353c0401e0);

Re: [PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10

From: Michael Ellerman <hidden>
Date: 2021-04-29 14:03:15

On Thu, 4 Mar 2021 01:40:15 -0500, Athira Rajeev wrote:
Memory events (mem-loads and mem-stores) currently use the threshold
event selection as issue to finish. Power10 supports issue to complete
as part of thresholding which is more appropriate for mem-loads and
mem-stores. Hence fix the event code for memory events to use issue
to complete.
Applied to powerpc/next.

[1/1] powerpc/perf: Fix the threshold event selection for memory events in power10
      https://git.kernel.org/powerpc/c/66d9b7492887d34c711bc05b36c22438acba51b4

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help