@@ -143,7 +143,7 @@ struct sba_device {u32max_xor_srcs;u32max_resp_pool_size;u32max_cmds_pool_size;-/* Maibox client and Mailbox channels */+/* Mailbox client and Mailbox channels */structmbox_clientclient;structmbox_chan*mchan;structdevice*mbox_dev;
@@ -328,7 +328,7 @@ static void sba_cleanup_nonpending_requests(struct sba_device *sba)spin_lock_irqsave(&sba->reqs_lock,flags);-/* Freeup all alloced request */+/* Freeup all allocated request */list_for_each_entry_safe(req,req1,&sba->reqs_alloc_list,node)_sba_free_request(sba,req);
@@ -1633,7 +1633,7 @@ static int sba_probe(struct platform_device *pdev)sba->dev=&pdev->dev;platform_set_drvdata(pdev,sba);-/* Number of mailbox channels should be atleast 1 */+/* Number of mailbox channels should be at least 1 */ret=of_count_phandle_with_args(pdev->dev.of_node,"mboxes","#mbox-cells");if(ret<=0)--
@@ -282,7 +282,7 @@ static void idma64_desc_fill(struct idma64_chan *idma64c,desc->length+=hw->len;}while(i);-/* Trigger an interrupt after the last block is transfered */+/* Trigger an interrupt after the last block is transferred */lli->ctllo|=IDMA64C_CTLL_INT_EN;/* Disable LLP transfer in the last block */
@@ -356,7 +356,7 @@ static size_t idma64_active_desc_size(struct idma64_chan *idma64c)if(!i)returnbytes;-/* The current chunk is not fully transfered yet */+/* The current chunk is not fully transferred yet */bytes+=desc->hw[--i].len;returnbytes-IDMA64C_CTLH_BLOCK_TS(ctlhi);--
@@ -369,7 +369,7 @@ static struct bcm2835_desc *bcm2835_dma_create_cb_chain(/* the last frame requires extra flags */d->cb_list[d->frames-1].cb->info|=finalextrainfo;-/* detect a size missmatch */+/* detect a size mismatch */if(buf_len&&(d->size!=buf_len))gotoerror_cb;--
@@ -1074,7 +1074,7 @@ mv_xor_channel_add(struct mv_xor_device *xordev,if(!mv_chan->dma_desc_pool_virt)returnERR_PTR(-ENOMEM);-/* discover transaction capabilites from the platform data */+/* discover transaction capabilities from the platform data */dma_dev->cap_mask=cap_mask;INIT_LIST_HEAD(&dma_dev->channels);--
@@ -243,7 +243,7 @@ static void iop_adma_tasklet(struct tasklet_struct *t)structiop_adma_chan*iop_chan=from_tasklet(iop_chan,t,irq_tasklet);-/* lockdep will flag depedency submissions as potentially+/* lockdep will flag dependency submissions as potentially*recursivelocking,thisisnotthecaseasadependency*submissionwillneverrecurseachannelssubmitroutine.*Therearechecksinasync_tx.ctopreventthis.
@@ -1302,7 +1302,7 @@ static int iop_adma_probe(struct platform_device *pdev)adev->id=plat_data->hw_id;-/* discover transaction capabilites from the platform data */+/* discover transaction capabilities from the platform data */dma_dev->cap_mask=plat_data->cap_mask;adev->pdev=pdev;--
@@ -23,7 +23,7 @@#include"dmaengine.h"-/* X-Gene DMA ring csr registers and bit definations */+/* X-Gene DMA ring csr registers and bit definitions */#define XGENE_DMA_RING_CONFIG 0x04#define XGENE_DMA_RING_ENABLE BIT(31)#define XGENE_DMA_RING_ID 0x08
@@ -102,7 +102,7 @@#define XGENE_DMA_BLK_MEM_RDY_VAL 0xFFFFFFFF#define XGENE_DMA_RING_CMD_SM_OFFSET 0x8000-/* X-Gene SoC EFUSE csr register and bit defination */+/* X-Gene SoC EFUSE csr register and bit definition */#define XGENE_SOC_JTAG1_SHADOW 0x18#define XGENE_DMA_PQ_DISABLE_MASK BIT(13)
@@ -870,7 +870,7 @@ atc_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,atc_desc_chain(&first,&prev,desc);}-/* First descriptor of the chain embedds additional information */+/* First descriptor of the chain embeds additional information */first->txd.cookie=-EBUSY;first->total_len=len;
@@ -1199,7 +1199,7 @@ atc_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,/* set end-of-link to the last link descriptor of list*/set_desc_eol(prev);-/* First descriptor of the chain embedds additional information */+/* First descriptor of the chain embeds additional information */first->txd.cookie=-EBUSY;first->total_len=total_len;
@@ -1358,7 +1358,7 @@ atc_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf_addr, size_t buf_len,/* lets make a cyclic list */prev->lli.dscr=first->txd.phys;-/* First descriptor of the chain embedds additional information */+/* First descriptor of the chain embeds additional information */first->txd.cookie=-EBUSY;first->total_len=buf_len;--
@@ -379,7 +379,7 @@ static struct dma_async_tx_descriptor *jz4780_dma_prep_slave_sg(if(i!=(sg_len-1)&&!(jzdma->soc_data->flags&JZ_SOC_DATA_BREAK_LINKS)){-/* Automatically proceeed to the next descriptor. */+/* Automatically proceed to the next descriptor. */desc->desc[i].dcm|=JZ_DMA_DCM_LINK;/*--
s/Synopsys/Synopsis/ .....two different places.
..and for some unknown reason it introduce a empty line deleted and added
back.
Signed-off-by: Bhaskar Chowdhury <redacted>
---
drivers/dma/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
@@ -1970,7 +1970,7 @@ static int d40_config_memcpy(struct d40_chan *d40c)dma_has_cap(DMA_SLAVE,cap)){d40c->dma_cfg=dma40_memcpy_conf_phy;-/* Generate interrrupt at end of transfer or relink. */+/* Generate interrupt at end of transfer or relink. */d40c->dst_def_cfg|=BIT(D40_SREG_CFG_TIM_POS);/* Generate interrupt on error. */
@@ -3415,7 +3415,7 @@ static int __init d40_lcla_allocate(struct d40_base *base)base->lcla_pool.base=(void*)page_list[i];}else{/*-*Aftermanyattemptsandnosucceeswithfindingthecorrect+*Aftermanyattemptsandnosuccesswithfindingthecorrect*alignment,trywithallocatingabigbuffer.*/dev_warn(base->dev,--
@@ -1056,10 +1056,10 @@ static irqreturn_t dw_axi_dma_interrupt(int irq, void *dev_id)u32status,i;-/* Disable DMAC inerrupts. We'll enable them after processing chanels */+/* Disable DMAC interrupts. We'll enable them after processing channels */axi_dma_irq_disable(chip);-/* Poll, clear and process every chanel interrupt status */+/* Poll, clear and process every channel interrupt status */for(i=0;i<dw->hdata->nr_channels;i++){chan=&dw->chan[i];status=axi_chan_irq_read(chan);
@@ -301,7 +301,7 @@ static struct usb_dmac_desc *usb_dmac_desc_get(struct usb_dmac_chan *chan,structusb_dmac_desc*desc=NULL;unsignedlongflags;-/* Get a freed descritpor */+/* Get a freed descriptor */spin_lock_irqsave(&chan->vc.lock,flags);list_for_each_entry(desc,&chan->desc_freed,node){if(sg_len<=desc->sg_allocated_len){--
From: Christoph Hellwig <hch@lst.de> Date: 2021-03-29 05:29:48
I really don't think these typo patchbomb are that useful. I'm all
for fixing typos when working with a subsystem, but I'm not sure these
patchbombs help anything.
On Mon, Mar 29, 2021 at 05:22:56AM +0530, Bhaskar Chowdhury wrote:
This patch series fixes some trivial and rudimentary spellings in the COMMENT
sections.
Bhaskar Chowdhury (30):
acpi-dma.c: Fix couple of typos
altera-msgdma.c: Couple of typos fixed
amba-pl08x.c: Fixed couple of typos
bcm-sba-raid.c: Few typos fixed
bcm2835-dma.c: Fix a typo
idma64.c: Fix couple of typos
iop-adma.c: Few typos fixed
mv_xor.c: Fix a typo
mv_xor.h: Fixed a typo
mv_xor_v2.c: Fix a typo
nbpfaxi.c: Fixed a typo
of-dma.c: Fixed a typo
s3c24xx-dma.c: Fix a typo
Revert "s3c24xx-dma.c: Fix a typo"
s3c24xx-dma.c: Few typos fixed
st_fdma.h: Fix couple of typos
ste_dma40_ll.h: Fix a typo
tegra20-apb-dma.c: Fixed a typo
xgene-dma.c: Few spello fixes
at_hdmac.c: Quite a few spello fixes
owl-dma.c: Fix a typo
at_hdmac_regs.h: Couple of typo fixes
dma-jz4780.c: Fix a typo
Kconfig: Change Synopsys to Synopsis
ste_dma40.c: Few spello fixes
dw-axi-dmac-platform.c: Few typos fixed
dpaa2-qdma.c: Fix a typo
usb-dmac.c: Fix a typo
edma.c: Fix a typo
xilinx_dma.c: Fix a typo
drivers/dma/Kconfig | 8 ++++----
drivers/dma/acpi-dma.c | 4 ++--
drivers/dma/altera-msgdma.c | 4 ++--
drivers/dma/amba-pl08x.c | 4 ++--
drivers/dma/at_hdmac.c | 14 +++++++-------
drivers/dma/at_hdmac_regs.h | 4 ++--
drivers/dma/bcm-sba-raid.c | 8 ++++----
drivers/dma/bcm2835-dma.c | 2 +-
drivers/dma/dma-jz4780.c | 2 +-
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 8 ++++----
drivers/dma/idma64.c | 4 ++--
drivers/dma/iop-adma.c | 6 +++---
drivers/dma/mv_xor.c | 2 +-
drivers/dma/mv_xor.h | 2 +-
drivers/dma/mv_xor_v2.c | 2 +-
drivers/dma/nbpfaxi.c | 2 +-
drivers/dma/of-dma.c | 2 +-
drivers/dma/owl-dma.c | 2 +-
drivers/dma/s3c24xx-dma.c | 6 +++---
drivers/dma/sh/shdmac.c | 2 +-
drivers/dma/sh/usb-dmac.c | 2 +-
drivers/dma/st_fdma.h | 4 ++--
drivers/dma/ste_dma40.c | 10 +++++-----
drivers/dma/ste_dma40_ll.h | 2 +-
drivers/dma/tegra20-apb-dma.c | 2 +-
drivers/dma/ti/edma.c | 2 +-
drivers/dma/xgene-dma.c | 6 +++---
drivers/dma/xilinx/xilinx_dma.c | 2 +-
28 files changed, 59 insertions(+), 59 deletions(-)
--
2.26.3
On 07:29 Mon 29 Mar 2021, Christoph Hellwig wrote:
I really don't think these typo patchbomb are that useful. I'm all
for fixing typos when working with a subsystem, but I'm not sure these
patchbombs help anything.
I am sure you are holding the wrong end of the wand and grossly failing to
understand.
Anyway, I hope I give a heads up ...find "your way" to fix those damn
thing...it's glaring....
On Mon, Mar 29, 2021 at 05:22:56AM +0530, Bhaskar Chowdhury wrote:
quoted
This patch series fixes some trivial and rudimentary spellings in the COMMENT
sections.
Bhaskar Chowdhury (30):
acpi-dma.c: Fix couple of typos
altera-msgdma.c: Couple of typos fixed
amba-pl08x.c: Fixed couple of typos
bcm-sba-raid.c: Few typos fixed
bcm2835-dma.c: Fix a typo
idma64.c: Fix couple of typos
iop-adma.c: Few typos fixed
mv_xor.c: Fix a typo
mv_xor.h: Fixed a typo
mv_xor_v2.c: Fix a typo
nbpfaxi.c: Fixed a typo
of-dma.c: Fixed a typo
s3c24xx-dma.c: Fix a typo
Revert "s3c24xx-dma.c: Fix a typo"
s3c24xx-dma.c: Few typos fixed
st_fdma.h: Fix couple of typos
ste_dma40_ll.h: Fix a typo
tegra20-apb-dma.c: Fixed a typo
xgene-dma.c: Few spello fixes
at_hdmac.c: Quite a few spello fixes
owl-dma.c: Fix a typo
at_hdmac_regs.h: Couple of typo fixes
dma-jz4780.c: Fix a typo
Kconfig: Change Synopsys to Synopsis
ste_dma40.c: Few spello fixes
dw-axi-dmac-platform.c: Few typos fixed
dpaa2-qdma.c: Fix a typo
usb-dmac.c: Fix a typo
edma.c: Fix a typo
xilinx_dma.c: Fix a typo
drivers/dma/Kconfig | 8 ++++----
drivers/dma/acpi-dma.c | 4 ++--
drivers/dma/altera-msgdma.c | 4 ++--
drivers/dma/amba-pl08x.c | 4 ++--
drivers/dma/at_hdmac.c | 14 +++++++-------
drivers/dma/at_hdmac_regs.h | 4 ++--
drivers/dma/bcm-sba-raid.c | 8 ++++----
drivers/dma/bcm2835-dma.c | 2 +-
drivers/dma/dma-jz4780.c | 2 +-
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 8 ++++----
drivers/dma/idma64.c | 4 ++--
drivers/dma/iop-adma.c | 6 +++---
drivers/dma/mv_xor.c | 2 +-
drivers/dma/mv_xor.h | 2 +-
drivers/dma/mv_xor_v2.c | 2 +-
drivers/dma/nbpfaxi.c | 2 +-
drivers/dma/of-dma.c | 2 +-
drivers/dma/owl-dma.c | 2 +-
drivers/dma/s3c24xx-dma.c | 6 +++---
drivers/dma/sh/shdmac.c | 2 +-
drivers/dma/sh/usb-dmac.c | 2 +-
drivers/dma/st_fdma.h | 4 ++--
drivers/dma/ste_dma40.c | 10 +++++-----
drivers/dma/ste_dma40_ll.h | 2 +-
drivers/dma/tegra20-apb-dma.c | 2 +-
drivers/dma/ti/edma.c | 2 +-
drivers/dma/xgene-dma.c | 6 +++---
drivers/dma/xilinx/xilinx_dma.c | 2 +-
28 files changed, 59 insertions(+), 59 deletions(-)
--
2.26.3
On Mon, Mar 29, 2021 at 11:25:11AM +0530, Bhaskar Chowdhury wrote:
On 07:29 Mon 29 Mar 2021, Christoph Hellwig wrote:
quoted
I really don't think these typo patchbomb are that useful. I'm all
for fixing typos when working with a subsystem, but I'm not sure these
patchbombs help anything.
I am sure you are holding the wrong end of the wand and grossly failing to
understand.
Please stop statements like this, it is not helpful and is doing nothing
but ensure that your patches will not be looked at in the future.
Anyway, I hope I give a heads up ...find "your way" to fix those damn
thing...it's glaring....
There is no requirement that anyone accept patches that are sent to
them. When you complain when receiving comments on them, that
shows you do not wish to work with others.
Sorry, but you are now on my local blacklist for a while, and I
encourage other maintainers to just ignore these patches as well.
thanks,
greg k-h
On Mon, Mar 29, 2021 at 11:25:11AM +0530, Bhaskar Chowdhury wrote:
quoted
On 07:29 Mon 29 Mar 2021, Christoph Hellwig wrote:
quoted
I really don't think these typo patchbomb are that useful. I'm all
for fixing typos when working with a subsystem, but I'm not sure these
patchbombs help anything.
I am sure you are holding the wrong end of the wand and grossly failing to
understand.
Please stop statements like this, it is not helpful and is doing nothing
but ensure that your patches will not be looked at in the future.
Greg, don't you think you are bit harsh and have an one sided view? People can
say in better way if they don't like some work. I Have always try to get
along.
quoted
Anyway, I hope I give a heads up ...find "your way" to fix those damn
thing...it's glaring....
There is no requirement that anyone accept patches that are sent to
them. When you complain when receiving comments on them, that
shows you do not wish to work with others.
Unfortunate you are only seeing my complains...I don't know why you are so
blindfolded.
Sorry, but you are now on my local blacklist for a while, and I
encourage other maintainers to just ignore these patches as well.
I can not overrule that ...I know my pathes are trivial ..but it seems some
other problems are looming large.
NOT good Greg....not good seriously.
From: Robin Murphy <robin.murphy@arm.com> Date: 2021-03-30 11:44:12
On 2021-03-29 00:53, Bhaskar Chowdhury wrote:
s/Synopsys/Synopsis/ .....two different places.
Erm, that is definitely not a typo... :/
..and for some unknown reason it introduce a empty line deleted and added
back.
Presumably your editor is configured to trim trailing whitespace on save.
Furthermore, there are several instances in the other patches where your
"corrections" are grammatically incorrect, I'm not sure what the deal is
with patch #14, and you've also used the wrong subsystem name (it should
be "dmaengine"). It's great to want to clean things up, but please pay a
bit of care and attention to what you're actually doing.
Robin.
s/transferred/transfered/
This reverts commit a2ddb8aea8106bd5552f8516ad7a8a26b9282a8f.
This is not upstream, why not squash in. Also would make sense to write
sensible changelog and not phrases and use the right subsystem
conventions!
Droped the series now
--
~Vinod
..and for some unknown reason it introduce a empty line deleted and added
back.
Presumably your editor is configured to trim trailing whitespace on save.
Furthermore, there are several instances in the other patches where your
"corrections" are grammatically incorrect, I'm not sure what the deal is
with patch #14, and you've also used the wrong subsystem name (it should
be "dmaengine"). It's great to want to clean things up, but please pay a
bit of care and attention to what you're actually doing.