Thread (6 messages) flat view 6 messages, 4 authors, 2021-03-19

Re: [PATCH] ASoC: fsl_sai: remove reset code from dai_probe

From: Shengjiu Wang <shengjiu.wang@gmail.com>
Date: 2021-03-16 13:34:28
Also in: alsa-devel, lkml

On Tue, Mar 16, 2021 at 9:01 PM Mark Brown [off-list ref] wrote:
On Tue, Mar 16, 2021 at 05:27:06PM +0800, Shengjiu Wang wrote:
quoted
From: Viorel Suman <redacted>

SAI software reset is done in runtime resume,
there is no need to do it in fsl_sai_dai_probe.
People can disable runtime PM in their configurations - do you not still
need a reset on probe in case there's no runtime PM?  It'd probably make
sense to factor the rest code out itno a function though.
Right, didn't consider the case of disable runtime PM.
Will move the reset code to a function.

Best regards
wang shengjiu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help