Thread (2 messages) flat view 2 messages, 2 authors, 2021-03-04

Re: [PATCH v2] crypto/nx: add missing call to of_node_put()

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2021-03-04 06:47:11
Also in: linux-crypto, lkml

On Fri, Feb 26, 2021 at 09:23:06AM +0800, Yang Li wrote:
In one of the error paths of the for_each_child_of_node() loop,
add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 936.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Yang Li <redacted>
---

Changes in v2:
-add braces for if

 drivers/crypto/nx/nx-common-powernv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Patch applied.  Thanks.
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help