Re: [PATCH v2 1/2] ima: Free IMA measurement buffer on error

Hi all,

<snip>

quoted

quoted

quoted

<formletter>

quoted

quoted

quoted

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

quoted

quoted

quoted

</formletter>

quoted

quoted

Thanks for the info Greg.

quoted

quoted

I will re-submit the two patches in the proper format.

quoted

No need.  I'm testing these patches now.  I'm not exactly sure what the
problem is.  Stable wasn't Cc'ed.  Is it that you sent the patch
directly to Greg or added "Fixes"?

I had not Cced stable, but had "Fixes" tag in the patch.

Fixes: 7b8589cc29e7 ("ima: on soft reboot, save the measurement list")

The problem is that the buffer allocated for forwarding the IMA measurement
list is not freed - at the end of the kexec call and also in an error path.
Please see the patch description for

[PATCH v2 2/2] ima: Free IMA measurement buffer after kexec syscall

IMA allocates kernel virtual memory to carry forward the measurement
list, from the current kernel to the next kernel on kexec system call,
in ima_add_kexec_buffer() function.  This buffer is not freed before
completing the kexec system call resulting in memory leak.

thanks,
 -lakshmi

Mimi, Lakshmi, it looks like these two fixes haven't been submitted to stable kernels.
Could you please submit them?

Thanks a lot!

Kind regards,
Petr