Thread (2 messages) 2 messages, 2 authors, 2021-02-18

Re: [PATCH 4/4] ASoC: fsl: drop unneeded snd_soc_dai_set_drvdata

From: Nicolin Chen <nicoleotsuka@gmail.com>
Date: 2021-02-18 06:43:58
Also in: alsa-devel, kernel-janitors, lkml

On Sat, Feb 13, 2021 at 11:19:07AM +0100, Julia Lawall wrote:
snd_soc_dai_set_drvdata is not needed when the set data comes from
snd_soc_dai_get_drvdata or dev_get_drvdata.  The problem was fixed
usingthe following semantic patch: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,y,e;
@@
	x = dev_get_drvdata(y->dev)
	... when != x = e
-	snd_soc_dai_set_drvdata(y,x);

@@
expression x,y,e;
@@
	x = snd_soc_dai_get_drvdata(y)
	... when != x = e
-	snd_soc_dai_set_drvdata(y,x);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help