Thread (31 messages) 31 messages, 6 authors, 2021-02-08

Re: [PATCH 10/13] module: pass struct find_symbol_args to find_symbol

From: Christoph Hellwig <hch@lst.de>
Date: 2021-02-02 15:43:40
Also in: linux-kbuild, live-patching, lkml

On Tue, Feb 02, 2021 at 03:07:51PM +0100, Miroslav Benes wrote:
quoted
 	preempt_disable();
-	sym = find_symbol(symbol, &owner, NULL, NULL, true, true);
-	if (sym && strong_try_module_get(owner))
-		sym = NULL;
+	if (!find_symbol(&fsa) || !strong_try_module_get(fsa.owner)) {
I think this should be in fact

  if (!find_symbol(&fsa) || strong_try_module_get(fsa.owner)) {

to get the logic right (note the missing !). We want to return NULL if 
strong_try_module_get() does not succeed for a found symbol.
Indeed. Fixed for the next version.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help