Thread (5 messages) 5 messages, 4 authors, 2021-01-21

Re: [PATCH net] ibmvnic: device remove has higher precedence over reset

From: Lijun Pan <hidden>
Date: 2021-01-21 19:51:33
Also in: netdev

quoted
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index aed985e08e8a..11f28fd03057 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -2235,8 +2235,7 @@ static void __ibmvnic_reset(struct work_struct
*work)
      while (rwi) {
              spin_lock_irqsave(&adapter->state_lock, flags);

-             if (adapter->state == VNIC_REMOVING ||
-                 adapter->state == VNIC_REMOVED) {
+             if (adapter->state == VNIC_REMOVED) {
If we do get here, we would crash because ibmvnic_remove() happened. It
frees the adapter struct already.
Not exactly. viodev is gone; netdev is gone; ibmvnic_adapter is still there.

Lijun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help