Re: [PATCH v5 15/21] powerpc/64s: reconcile interrupts in C
From: Nicholas Piggin <npiggin@gmail.com>
Date: 2021-01-14 03:53:30
Excerpts from Christophe Leroy's message of January 14, 2021 12:54 am:
Le 13/01/2021 à 08:32, Nicholas Piggin a écrit :quoted
There is no need for this to be in asm, use the new intrrupt entry wrapper. Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- arch/powerpc/include/asm/interrupt.h | 15 +++++++++++---- arch/powerpc/kernel/exceptions-64s.S | 26 -------------------------- 2 files changed, 11 insertions(+), 30 deletions(-)diff --git a/arch/powerpc/include/asm/interrupt.h b/arch/powerpc/include/asm/interrupt.h index 34d7cca2cb2e..6eba7c489753 100644 --- a/arch/powerpc/include/asm/interrupt.h +++ b/arch/powerpc/include/asm/interrupt.h@@ -14,11 +14,14 @@ struct interrupt_state { static inline void interrupt_enter_prepare(struct pt_regs *regs, struct interrupt_state *state) { -#ifdef CONFIG_PPC_BOOK3E_64 - state->ctx_state = exception_enter(); -#endif -Can't the above stay on top of the function ?
It could but I prefer to do it this way because exception_enter needs the irq soft-mask state to be set up. It is E vs S, but it reads better this way (and one day I hope to get E to use C interrupt returns). Thanks, Nick