Re: [PATCH 1/2] ima: Free IMA measurement buffer on error
From: Tyler Hicks <hidden>
Date: 2021-01-21 17:38:03
Also in:
linux-integrity, lkml
On 2021-01-21 09:30:02, Lakshmi Ramasubramanian wrote:
IMA allocates kernel virtual memory to carry forward the measurement
list, from the current kernel to the next kernel on kexec system call,
in ima_add_kexec_buffer() function. In error code paths this memory
is not freed resulting in memory leak.
Free the memory allocated for the IMA measurement list in
the error code paths in ima_add_kexec_buffer() function.
Signed-off-by: Lakshmi Ramasubramanian <redacted>
Suggested-by: Tyler Hicks <redacted>
Fixes: 7b8589cc29e7 ("ima: on soft reboot, save the measurement list")Reviewed-by: Tyler Hicks <redacted> Tyler
quoted hunk ↗ jump to hunk
--- security/integrity/ima/ima_kexec.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/ima_kexec.c index 121de3e04af2..212145008a01 100644 --- a/security/integrity/ima/ima_kexec.c +++ b/security/integrity/ima/ima_kexec.c@@ -119,12 +119,14 @@ void ima_add_kexec_buffer(struct kimage *image) ret = kexec_add_buffer(&kbuf); if (ret) { pr_err("Error passing over kexec measurement buffer.\n"); + vfree(kexec_buffer); return; } ret = arch_ima_add_kexec_buffer(image, kbuf.mem, kexec_segment_size); if (ret) { pr_err("Error passing over kexec measurement buffer.\n"); + vfree(kexec_buffer); return; }-- 2.30.0