[PATCH 2/3] tty: vcc: Drop unnecessary if block
From: Uwe Kleine-König <hidden>
Date: 2021-01-14 17:59:22
Also in:
lkml, sparclinux
Subsystem:
sparc serial drivers, the rest, tty layer and serial drivers · Maintainers:
"David S. Miller", Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby
If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL value, and if vcc_probe() failed vcc_remove() isn't called. So there is no way dev_get_drvdata() can return NULL in vcc_remove() and the check can just go away. Signed-off-by: Uwe Kleine-König <redacted> --- drivers/tty/vcc.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c
index 9ffd42e333b8..d9b0dc6deae9 100644
--- a/drivers/tty/vcc.c
+++ b/drivers/tty/vcc.c@@ -681,9 +681,6 @@ static int vcc_remove(struct vio_dev *vdev) { struct vcc_port *port = dev_get_drvdata(&vdev->dev); - if (!port) - return -ENODEV; - del_timer_sync(&port->rx_timer); del_timer_sync(&port->tx_timer);
--
2.29.2