On Wed, Jan 13, 2021 at 12:51:26PM +0100, Christoph Hellwig wrote:

On Wed, Jan 06, 2021 at 08:50:03AM +0100, Greg KH wrote:

quoted

quoted

--- a/include/linux/device.h
+++ b/include/linux/device.h

@@ -413,6 +413,7 @@ struct dev_links_info {
  * @dma_pools:	Dma pools (if dma'ble device).
  * @dma_mem:	Internal for coherent mem override.
  * @cma_area:	Contiguous memory area for dma allocations
+ * @dma_io_tlb_mem: Internal for swiotlb io_tlb_mem override.

Why does this have to be added here?  Shouldn't the platform-specific
code handle it instead?

The whole code added here is pretty generic.  What we need to eventually
do, though is to add a separate dma_device instead of adding more and more
bloat to struct device.

I have no objections for that happening!