Thread (4 messages) 4 messages, 4 authors, 2021-02-03

Re: [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock

flat view

From: Frederic Barrat <hidden>
Date: 2021-01-04 08:51:15
Also in: lkml


On 24/12/2020 14:24, Zheng Yongjun wrote:
mutex lock can be initialized automatically with DEFINE_MUTEX()
rather than explicitly calling mutex_init().

Signed-off-by: Zheng Yongjun <redacted>
---

Thanks!
Acked-by: Frederic Barrat <redacted>


quoted hunk ↗ jump to hunk
  drivers/misc/ocxl/file.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
index 4d1b44de1492..e70525eedaae 100644
--- a/drivers/misc/ocxl/file.c
+++ b/drivers/misc/ocxl/file.c
@@ -15,7 +15,7 @@
  
  static dev_t ocxl_dev;
  static struct class *ocxl_class;
-static struct mutex minors_idr_lock;
+static DEFINE_MUTEX(minors_idr_lock);
  static struct idr minors_idr;
  
  static struct ocxl_file_info *find_and_get_file_info(dev_t devno)
@@ -588,7 +588,6 @@ int ocxl_file_init(void)
  {
  	int rc;
  
-	mutex_init(&minors_idr_lock);
  	idr_init(&minors_idr);
  
  	rc = alloc_chrdev_region(&ocxl_dev, 0, OCXL_NUM_MINORS, "ocxl");
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help