Thread (23 messages) 23 messages, 3 authors, 2020-12-21

Re: [PATCH 01/23] kernel: irq: irqdescs: warn on spurious IRQ

From: Andy Shevchenko <hidden>
Date: 2020-12-21 10:08:35
Also in: linux-alpha, linux-arch, linux-gpio, linux-m68k, linux-mips, linux-omap, linux-s390, linux-sh, lkml, sparclinux

On Mon, Dec 21, 2020 at 7:44 AM Michael Ellerman [off-list ref] wrote:
Andy Shevchenko [off-list ref] writes:
quoted
On Fri, Dec 18, 2020 at 4:37 PM Enrico Weigelt, metux IT consult
[off-list ref] wrote:
quoted
+               if (printk_ratelimit())
+                       pr_warn("spurious IRQ: irq=%d hwirq=%d nr_irqs=%d\n",
+                               irq, hwirq, nr_irqs);
Perhaps you missed pr_warn_ratelimit() macro which is already in the
kernel for a long time.
pr_warn_ratelimited() which calls printk_ratelimited().
I stand corrected.
Right, that's what I had in mind (actually didn't know that there are variants).

Thanks!
And see the comment above printk_ratelimit():

/*
 * Please don't use printk_ratelimit(), because it shares ratelimiting state
 * with all other unrelated printk_ratelimit() callsites.  Instead use
 * printk_ratelimited() or plain old __ratelimit().
 */

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help