Thread (45 messages) flat view 45 messages, 3 authors, 2020-12-05

Re: [PATCH 02/29] powerpc/rtas: prevent suspend-related sys_rtas use on LE

From: Nathan Lynch <hidden>
Date: 2020-11-06 16:46:58

Andrew Donnellan [off-list ref] writes:
On 30/10/20 11:10 pm, Nathan Lynch wrote:
quoted
quoted
And there's a zero chance that drmgr will ever be fixed on LE?
It's always used the sysfs interface on LE, and the only way to provoke
it to attempt the syscalls is by doing something like this before
running the migration:

# echo 0 > /tmp/fake_api_version
# mount -o bind,ro /tmp/fake_api_version /sys/kernel/mobility/api_version

So I'm not aware of any circumstance that would actually motivate
someone to make it work on LE. I'd say it's more likely that drmgr will
drop its support for using the syscall altogether.
Okay. librtas should handle the error fine, so I don't have any huge 
objection to this, though perhaps a documentation patch to librtas to 
mention that these calls are BE-only would be in order.
Good suggestion, I've drafted a documentation change as well as an
attempt to mark the appropriate APIs deprecated for LE here:

https://github.com/nathanlynch/librtas/tree/topic/document-suspend-filter

which I'll send to Tyrel if/when the Linux change is staged.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help