Re: [PATCH 3/3] powerpc: fix -Wimplicit-fallthrough
From: Miguel Ojeda <hidden>
Date: 2020-11-16 12:38:04
Also in:
lkml
From: Miguel Ojeda <hidden>
Date: 2020-11-16 12:38:04
Also in:
lkml
On Mon, Nov 16, 2020 at 5:35 AM Nick Desaulniers [off-list ref] wrote:
The "fallthrough" pseudo-keyword was added as a portable way to denote intentional fallthrough. Clang will still warn on cases where there is a fallthrough to an immediate break. Add explicit breaks for those cases. Link: https://github.com/ClangBuiltLinux/linux/issues/236 Signed-off-by: Nick Desaulniers <redacted>
It makes things clearer having a `break` added, so I like that warning. Reviewed-by: Miguel Ojeda <ojeda@kernel.org> Cheers, Miguel