Thread (52 messages) 52 messages, 8 authors, 2020-10-15

Re: [PATCH v4 00/13] mm/debug_vm_pgtable fixes

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2020-10-14 20:36:13
Also in: linux-mm

On Wed, 14 Oct 2020 08:45:16 +0530 "Aneesh Kumar K.V" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
quoted
Against mm-debug_vm_pgtable-avoid-none-pte-in-pte_clear_test.patch:

https://lkml.kernel.org/r/87zh5wx51b.fsf@linux.ibm.com

yes this one we should get fixed. I was hoping someone familiar with 
Riscv pte updates rules would pitch in. IIUC we need to update 
RANDON_ORVALUE similar to how we updated it for s390 and ppc64.


  Alternatively we can do this

modified   mm/debug_vm_pgtable.c
@@ -548,7 +548,7 @@ static void __init pte_clear_tests(struct mm_struct 
*mm, pte_t *ptep,
  	pte_t pte = pfn_pte(pfn, prot);

  	pr_debug("Validating PTE clear\n");
-	pte = __pte(pte_val(pte) | RANDOM_ORVALUE);
+//	pte = __pte(pte_val(pte) | RANDOM_ORVALUE);
  	set_pte_at(mm, vaddr, ptep, pte);
  	barrier();
  	pte_clear(mm, vaddr, ptep);

till we get that feedback from RiscV team?
Would it be better to do

#ifdef CONFIG_S390
	pte = __pte(pte_val(pte) | RANDOM_ORVALUE);
#endif

?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help