Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

From
Serge Semin <hidden>
Date
2020-10-14 21:23:12
Also in
linux-arm-kernel, linux-arm-msm, linux-devicetree, linux-mips, linux-omap, linux-samsung-soc, linux-usb, lkml
Reply to
Rob Herring, 2020-10-14
On Wed, Oct 14, 2020 at 01:35:16PM -0500, Rob Herring wrote:
On Wed, Oct 14, 2020 at 9:37 AM Serge Semin
[off-list ref] wrote:
quoted
On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote:
quoted
Hi Serge,

Serge Semin [off-list ref] writes:
quoted
In accordance with the DWC USB3 bindings the corresponding node name is
suppose to comply with Generic USB HCD DT schema, which requires the USB
quoted
DWC3 is not a simple HDC, though.
Yeah, strictly speaking it is equipped with a lot of vendor-specific stuff,
which are tuned by the DWC USB3 driver in the kernel. But after that the
controller is registered as xhci-hcd device so it's serviced by the xHCI driver,
which then registers the HCD device so the corresponding DT node is supposed
to be compatible with the next bindings: usb/usb-hcd.yaml, usb/usb-xhci.yaml
and usb/snps,dwc3,yaml. I've created the later one so to validate the denoted
compatibility.
quoted
quoted
nodes to have the name acceptable by the regexp: "^usb(@.*)?" . But a lot
of the DWC USB3-compatible nodes defined in the ARM/ARM64 DTS files have
name as "^dwc3@.*" or "^usb[1-3]@.*" or even "^dwusb@.*", which will cause
the dtbs_check procedure failure. Let's fix the nodes naming to be
compatible with the DWC USB3 DT schema to make dtbs_check happy.

Note we don't change the DWC USB3-compatible nodes names of
arch/arm64/boot/dts/apm/{apm-storm.dtsi,apm-shadowcat.dtsi} since the
in-source comment says that the nodes name need to be preserved as
"^dwusb@.*" for some backward compatibility.
quoted
interesting, compatibility with what? Some debugfs files, perhaps? :-)
Don't really know.) In my experience the worst type of such compatibility is
connected with some bootloader magic, which may add/remove/modify properties
to nodes with pre-defined names.
I seriously doubt anyone is using the APM machines with DT (even ACPI
is somewhat doubtful). I say change them. Or remove the dts files and
see what happens. Either way it can always be reverted.
Ok. I'll change them in v3.

-Sergey
Rob
Thread (73 messages) 73 messages, 13 authors, last reply 2020-10-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help