Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

On Thu, Oct 1, 2020 at 1:19 PM Joe Perches [off-list ref] wrote:

On Thu, 2020-10-01 at 14:39 -0500, Segher Boessenkool wrch/ote:

quoted

Hi!

On Thu, Oct 01, 2020 at 12:15:39PM +0200, Miguel Ojeda wrote:

quoted

quoted

So it looks like the best option is to exclude these
2 files from conversion.

Agreed. Nevertheless, is there any reason arch/powerpc/* should not be
compiling cleanly with compiler.h? (CC'ing the rest of the PowerPC
reviewers and ML).

You need to #include compiler_types.h to get this #define?

Actually no, you need to add

#include <linux/compiler_attributes.h>

to both files and then it builds properly.

Ideally though nothing should include this file directly.

That's because Kbuild injects it via command line flag `-include`.
(Well, it injects compiler_types.h which includes this).  If part of
the tree reset KBUILD_CFLAGS, that `-include` gets dropped.  I don't
think there's anything wrong with manually including it and adding `-I
<path>` (capital i) if needed.

quoted

(The twice-defined thing is a warning, not an error.  It should be fixed
of course, but it is less important; although it may be pointing to a
deeper problem.)


Segher

-- 
Thanks,
~Nick Desaulniers